Add logs for GSB http proxy #3304
Conversation
… doesn't cause call rejection
| @@ -53,9 +53,9 @@ impl GsbToHttpProxy { | |||
|
|
|||
| pub fn bind(&mut self, gsb_path: &str) -> Handle { | |||
| let this = self.clone(); | |||
| bus::bind(gsb_path, move |message: GsbHttpCallMessage| { | |||
| bus::bind_with_caller(gsb_path, move |caller, message: GsbHttpCallMessage| { | |||
There was a problem hiding this comment.
Do I understand correctly that it aims to resolve golemfactory/ya-runtime-ai#105?
If so, how does it solve the problem if we don't make use of that parameter in pass() apart from logging? Or do we only want to log the messages for now and fix it after collecting more data?
There was a problem hiding this comment.
It doesn't. The problem mentioned is solved here: 27f9350
There was a problem hiding this comment.
Or do we solve the problem by switching authorize_activity_executor() to authorize_activity_initiator() and log to ensure that there are no problems with it after the change?
There was a problem hiding this comment.
Yes it's solves the problem with spam that reports incorrectly that something is wrong when it isn't.
I don't want to block possibility of using other yagna as proxy, so the call is not rejected even if it is from incorrect identity
resolves: golemfactory/ya-runtime-ai#105